Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Fix the unit test failure in JS Quick Edit and some typos in JSDoc.#4821

Merged
redmunds merged 1 commit into
masterfrom
rlim/js-quick-edit-unit-test
Aug 19, 2013
Merged

Fix the unit test failure in JS Quick Edit and some typos in JSDoc.#4821
redmunds merged 1 commit into
masterfrom
rlim/js-quick-edit-unit-test

Conversation

@RaymondLim
Copy link
Copy Markdown
Contributor

Fix the JS Quick Edit unit test failure introduced by #4637.

@ghost ghost assigned redmunds Aug 19, 2013
@redmunds
Copy link
Copy Markdown
Contributor

This fixes the test on both MacOS 10.8 and Win7, but it seems to have introduced 5 new errors on Win7:

should open a function with form: function functionName()

timeout: timed out after 1000 msec waiting for success toggleQuickEditAtOffset

should open a function with form: functionName = function()

timeout: timed out after 1000 msec waiting for success toggleQuickEditAtOffset

should open a function with form: functionName: function()

timeout: timed out after 1000 msec waiting for success toggleQuickEditAtOffset

should see code hint lists in quick editor

timeout: timed out after 1000 msec waiting for success Open quick editor

should see jump to definition on variable working in quick editor

timeout: timed out after 1000 msec waiting for success Open quick editor

@RaymondLim
Copy link
Copy Markdown
Contributor Author

@redmunds
Hmm... I'm not seeing those errors on my win7. I did find 5 instances of toggleQuickEditAtOffset in JS Quick Edit unittests.js. So I'm sure you're referring to running "Extensions" suite. Can you try to clean up Brackets cache and run again?

@redmunds
Copy link
Copy Markdown
Contributor

Deleting cache fixed it. Merging.

redmunds added a commit that referenced this pull request Aug 19, 2013
Fix the unit test failure in JS Quick Edit and some typos in JSDoc.
@redmunds redmunds merged commit 037c83a into master Aug 19, 2013
@redmunds redmunds deleted the rlim/js-quick-edit-unit-test branch August 19, 2013 22:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants